PWA

# Contribution

NOTE

Setting the project for contributors is briefly described as a part of local environment post - chapter 6.1.

# How to start

Before you start contributing, you should fork this repository and pick up the issue.

Issues, labeled with core-team, shopware-task are reserved for Shopware-PWA Core Team Members and Shopware Core Team.

To find community tasks click here (opens new window) or use following filter in the issues:

is:open is:issue -label:"Shopware Task" -label:"Core Team"

After choosing the task, you can solve the problem and create a pull request (PR). Feature requests should be discussed on our Discord channel (please see the link in README.md (opens new window)). After the discussion, please create the issue describing your request.

Github Project Broad is intended only for core developers.

Please read the code of conduct and follow it in all your interactions with the project.

Thank you for your interest and engagement! 😃

You may want to read:

# Branches

For all of the codebase changes please create a new branch. Its name should fit into this template: <task type eg. feat, fix, chore>/<package eg. cli, client, theme, if there is a global task this part can be omitted>/<short task description is written in kebab-case>-<issue number (also optional)>, here are some examples:

  • feat/theme/add-carousel-to-product-details
  • chore/update-project-dependencies
  • fix/cli/missing-dependencies-#233

# Commits

After resolving the pull request, all the commits will be automatically squashed into one. Any commit messages, which do not fit Conventional Commits (opens new window) convention would be not included in the list of commit messages. We do not recommend to squash the commits after opening the PR manually. To update your branch to the current master please use git merge.

# Tests

We keep 100% test coverage for our packages (except default-theme). Before opening a pull request, make sure all tests pass and coverage does not decrease. For further information please read the documentation.

Please, remember to always during development have opened terminal with yarn test --watch command fired.

# E2E Playwright tests

Critical paths in our default theme are checking if application flow is working correctly. To check tests locally you can run

# in local mode
yarn test:theme
# in graphic mode
yarn test:theme --headed

# Pull requests

  • The Pull requests title must match the Conventional Commits (opens new window) spec. If not, the PR will fail during the github action process.

  • In order to speed up the whole process, please allow us to edit your pull requests (you can mark a PR as editable during creating).

  • There is a Pull Request template, that contributors should follow. To merge a branch into master at least one core team member must accept the changes. All continuous integration checks must pass. Note that, only Shopware-PWA Core Team Members are allowed to accept pull requests.

  • If you face any problems during the implementation of the complex issue, feel free to implement just a part of it and ask for help in the comment. It's OK if you can only handle styling/tests/whatever.

  • In case of any problems feel free to contact us in comments or our Discord channel. 😃

  • After PR preview is generated we can add e2e-running label. It will fire GitHub Action with Playwright tests. After this action e2e-running label will be automatically removed, and instead there will be e2e-passed or e2e-failed label. In case of failure check locally by firing yarn test:theme.

← CLI →